Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

2015-12-08 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added inline comments. Comment at: lib/AST/ASTContext.cpp:429 @@ -432,2 +428,3 @@ + auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo); return CFC; } jroelofs wrote: > return new ... Will fix in commit. Repository:

Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

2015-12-08 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/AST/ASTContext.cpp:299 @@ -299,3 +298,3 @@ // specialization? -if (const ClassTemplateSpecializationDecl *CTSD = +if (const auto *CTSD = dyn_cast(CRD)) { Can this now fit onto one line?

Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

2015-12-08 Thread Jonathan Roelofs via cfe-commits
jroelofs added a subscriber: jroelofs. Comment at: lib/AST/ASTContext.cpp:429 @@ -432,2 +428,3 @@ + auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo); return CFC; } return new ... Repository: rL LLVM http://reviews.llvm.org/D15

[PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

2015-12-08 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-use-auto warnings. Autos are also used for pointer variables assi