arsenm added a comment.
Code looks fine, patch title is a bit confusing. Don't say codegen, and say
clang: Add elementwise pow builtin?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153310/new/
https://reviews.llvm.org/D153310
___
bob80905 added a comment.
Ping, can someone please take a look?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153310/new/
https://reviews.llvm.org/D153310
___
cfe-commits mailing list
cfe-commits@lists.l
bob80905 updated this revision to Diff 541721.
bob80905 added a comment.
- add newline EOF
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153310/new/
https://reviews.llvm.org/D153310
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNo
bob80905 updated this revision to Diff 541717.
bob80905 added a comment.
- add strictfp test, use emitbinarybuiltin, fix some whitespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153310/new/
https://reviews.llvm.org/D153310
Files:
clang/docs
arsenm added a comment.
Add a test for the strictfp case (there's an existing strictfp test for all the
elementwise builtins)
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3241
+unsigned Opc = llvm::Intrinsic::pow;
+Value* Result = Builder.CreateBinaryIntrinsic(Opc, Op0,
