probinson added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1761
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
aaron.ballman wrote:
> tbaeder wrote:
> > probinson wrot
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1761
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
tbaeder wrote:
> probinson wrote:
> > Would you mind
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1761
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
probinson wrote:
> Would you mind changing this cast from
probinson added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1761
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
Would you mind changing this cast from `uint8_t` to `uns
jplehr added a comment.
Wow, thanks for the quick fix!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153276/new/
https://reviews.llvm.org/D153276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
tbaeder added a comment.
Yeah sorry about that, but should already be fixed by
https://github.com/llvm/llvm-project/commit/47446939e0e60cf52ffdd3fa671949ff3183a4c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153276/new/
https://reviews.llvm.org/D
jplehr added a comment.
Hi,
this seems to have broken the OpenMP AMDGPU buildbot
(https://lab.llvm.org/buildbot/#/builders/193/builds/35471)
I'm happy to help if needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153276/new/
https://reviews.llv
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8c0246c7f517: [clang][Interp] Reject reinterpret_casts
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D153276?vs=533238&
tbaeder updated this revision to Diff 533238.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153276/new/
https://reviews.llvm.org/D153276
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/lib/AST/Interp/Disasm.cpp
clang/lib/AST/Interp/Int
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with the Dynamic bit pulled.
Comment at: clang/lib/AST/Interp/Interp.h:1854
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind)
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1854
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
aaron.ballman wrote:
> Should this be doing the cast? The
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/Interp.h:1854
+ S.FFDiag(Loc, diag::note_constexpr_invalid_cast)
+ << static_cast(Kind) << S.Current->getRange(OpPC);
+ return false;
Should this be doing the cast? The overloaded operat
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add a new `InvalidCast` op for this purpose and emi
13 matches
Mail list logo