[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. I've used something like `for i in llvm clang clang-tools flang lld lldb bolt mlir; do LIT_OPTS='--filter=xxx --allow-empty-runs' ninja -C /tmp/Rel check-$i` to ensure I have built everything, beside a few projects I run `check-$i`. It's always good to make the last-minu

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay added a comment. Glad that you landed the first change separately:) The Error.cpp change was reverted by b3c8554f28a95063e406924c25336e0da7efb4fd which was more focused. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa0dbd7bf35: [llvm] Move StringExtras.h include from Error.h to Error.cpp (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D153229?vs=533989&id=534347#toc Repository:

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @MaskRay good idea, I have split into 2 commits and pushed to the `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cf

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems that the main change is in `llvm/include/llvm/Support/Error.h`. I think there is a small but not negligible chance that this patch may cause a breakage for some build configurations. I

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533989. IncludeGuardian added a comment. Fix missing includes for Windows-only files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extr

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533968. IncludeGuardian added a comment. Add back all includes (bad arc change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extra/cla

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533966. IncludeGuardian added a comment. Fix missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: llvm/unittests/Support/CompressionTest.c

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. In D153229#134 , @IncludeGuardian wrote: > @barannikov88 no it's not. I was going to commit separately to keep the > change small, but it turns out that if I move this to the source file there > are no additional chang

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @barannikov88 no it's not. I was going to commit separately to keep the change small, but it turns out that if I move this to the source file there are no additional changes needed. SmallVector.h has now been moved to Error.cpp as well. Repository: rG LLVM G

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533941. IncludeGuardian added a comment. Herald added subscribers: vkmr, kadircet, arphaman, emaste. Herald added a reviewer: bollu. Herald added a reviewer: aartbik. Herald added a reviewer: MaskRay. Herald added a project: clang-tools-extra. Fix comp

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. Is SmallVector.h still required in Error.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cfe-commits mailing list cfe-commi

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. Herald added a subscriber: jsetoain. This was found with IncludeGuardian 0.0.8. The line that suggested this can be found in the output here . The count of pre

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian created this revision. Herald added subscribers: bviyer, luke, Moerafaat, kmitropoulou, zero9178, steakhal, mtrofin, bzcheeseman, mattd, gchakrabarti, pmatos, asb, sdasgup3, asavonic, jeroen.dobbelaere, wenzhicui, wrengr, ormris, foad, ChuanqiXu, cota, teijeong, frasercrmck, rdzh