[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG44e63ffe2bf7: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532424. JOE1994 added a comment. - git clang-format (update clang/lib/CodGen/CGBlocks.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/CodeGen/

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto &byrefInfo = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532422. JOE1994 added a comment. - Apply suggested change (combining 2 lines) from barannikov88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/Cod

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto &byrefInfo = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532421. JOE1994 added a comment. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. - Rebase onto latest llvm-project main - Remove awkward empty line in `clang/lib/CodeGen/CGBlocks.cpp`, as suggested by barannikov88 Repository: rG LLVM Github Mo

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This needs to be rebased, there will be conflicts with 992cb984 . Comment at: clang/lib/CodeGen/CGBlocks.cpp:1264 -addr = Builder.Creat

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532404. JOE1994 added a comment. - Apply suggestions from @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/CodeGen/Address.h clang/lib/Code

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGObjC.cpp:2207 llvm::Type *origType = addr.getElementType(); - addr = CGF.Builder.CreateElementBitCast(addr, CGF.Int8PtrTy); + addr = a

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `Address::withElementType()` as a replacement for `CGBuilderTy::CreateElementBitCast`. - Partial progress towards re