[PATCH] D152989: Pre-commit test for D151696.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43baa5986c20: Pre-commit test for D151696. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D152989: Pre-commit test for D151696.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535223. FreddyYe added a comment. Seperate ALIAS CPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecific-cpus.c clang/te

[PATCH] D152989: Pre-commit test for D151696.

skan added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} FreddyYe wrote: > skan wrote: > > Shouldn't we use the same function name? > Emmm

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} skan wrote: > Shouldn't we use the same function name? Emmm... it would invo

[PATCH] D152989: Pre-commit test for D151696.

skan added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:12 + +ATTR(cpu_specific(generic)) void CPU0(void){} +ATTR(cpu_specific(pentium)) void CPU1(void){} Shouldn't we use the same function name? Repository: rG LLVM Github Monorepo

[PATCH] D152989: Pre-commit test for D151696.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535215. FreddyYe added a comment. Change into a more simplified style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecific-c

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. It came to me a better style: ATTR(cpu_specific(generic)) void CPU1(void){} ATTR(cpu_specific(pentium_pro)) void CPU2(void){} ATTR(cpu_specific(pentium_mmx)) void CPU3(void){} ATTR(cpu_specific(pentium_ii)) void CPU4(void){} ATTR(cpu_specific(pentium_iii)) void

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 535213. FreddyYe marked an inline comment as done. FreddyYe added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/Co

[PATCH] D152989: Pre-commit test for D151696.

pengfei added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:1-2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s +// RUN: %clang_cc1 -triple x86_64-windows-pc -fms-compatibility -emit-llvm -o - %s + Is it only to check no

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe updated this revision to Diff 534861. FreddyYe added a comment. Added more checks for resolver function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152989/new/ https://reviews.llvm.org/D152989 Files: clang/test/CodeGen/attr-cpuspecif

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. As mentioned in https://reviews.llvm.org/D151696, ping here, too. I want to land this patch first so that I could add some new Intel CPUs in this test supported in https://reviews.llvm.org/D151696 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Meanwhile this patch added missing tests for supported CPU names of cpu_dispatch/specific attribute. Repository: rG LL