Re: [PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

2015-12-11 Thread Aaron Ballman via cfe-commits
aaron.ballman abandoned this revision. aaron.ballman added a comment. Abandoning this revision, will post a new patch approach shortly. http://reviews.llvm.org/D15228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

2015-12-04 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. As I wade through a lot of diagnostics from our test suite, I notice a recurring pattern is that this is diagnosing in the presence of idiomatic constructors or assignment operators. e.g., struct S { S(const S&) = delete; S(S&); // We diagnose, and sugge

Re: [PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

2015-12-04 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. I should note for clarity, this is a WIP. There are still a lot of test cases that require updating due to the new diagnostic. I also wanted to get a feel for whether people felt this belongs under -Wall or not. http://reviews.llvm.org/D15228 _

[PATCH] D15228: [PATCH] New diagnostic for non-idiomatic copy or move operations

2015-12-04 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. aaron.ballman added a subscriber: cfe-commits. All copy operations were created equal (as far as the core language is concerned), but some copy operations are more equal than others (as far as the library is co