This revision was automatically updated to reflect the committed changes.
Closed by commit rG22e95e0bf375: [clang] Fix assertion while parsing an invalid
for loop (authored by cor3ntin).
Changed prior to commit:
https://reviews.llvm.org/D152009?vs=529186&id=529212#toc
Repository:
rG LLVM Git
cor3ntin updated this revision to Diff 529186.
cor3ntin added a comment.
Add tests for missing semi colons
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152009/new/
https://reviews.llvm.org/D152009
Files:
clang/docs/ReleaseNotes.rst
clang/lib/
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/test/Parser/cxx0x-for-range.cpp:67
+int a[] = {1, 2, 3, 4, 5};
+for (auto x = n ? 1 : 2 : a); // expected-error {{expected ';' in 'for'
statem
cor3ntin added inline comments.
Comment at: clang/lib/Parse/ParseStmt.cpp:2200
Diag(Tok, diag::err_expected_semi_for);
- else
-// Skip until semicolon or rparen, don't consume it.
shafik wrote:
> Can you explain why you removed this?
The cur
shafik added inline comments.
Comment at: clang/lib/Parse/ParseStmt.cpp:2200
Diag(Tok, diag::err_expected_semi_for);
- else
-// Skip until semicolon or rparen, don't consume it.
Can you explain why you removed this?
Commen
cor3ntin updated this revision to Diff 527902.
cor3ntin added a comment.
revert ws changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152009/new/
https://reviews.llvm.org/D152009
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Parse/ParseExprC
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
with multiple declarations followed by a colon.
Fixes #63010
Repository:
rG LLVM Github Monorepo
https://reviews.llv
