[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. apologies, i just realized its a new test that you xfailed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___ cfe-commits mailing lis

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. i think the extra two failures are not related to you patch. so ignore comment about these libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl1.c libomptarget :: amdgcn-amd-amdhsa :: jit/empty_kernel_lvl2.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. observing failure in our amdgpu buildbot , 3 tests see: https://lab.llvm.org/staging/#/builders/247/builds/947 7: __tgt_target_table *__tgt_rtl_load_binary(int32_t, __tgt_device_image *): Assertion `Table != nullptr && "Invalid table"' failed. if you have a quick fix, p

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Jennifer Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa419ec4f256d: Fix runtime crash inside __kmpc_init_allocator (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151576/new/ https://reviews.llvm.org/D151576 ___

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

2023-05-26 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. It seems load of traits.addr should be passed in r