This revision was automatically updated to reflect the committed changes.
Closed by commit rG9346dc6f675e: Add fastmath attributes to llvm.call_intrinsic
(authored by electriclilies, committed by Mogball).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
electriclilies updated this revision to Diff 526117.
electriclilies added a comment.
fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
mli
electriclilies updated this revision to Diff 526115.
electriclilies added a comment.
fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
electriclilies updated this revision to Diff 525831.
electriclilies added a comment.
format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
electriclilies added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleT
Mogball accepted this revision.
Mogball added inline comments.
This revision is now accepted and ready to land.
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:878
}];
- let arguments = (ins StrAttr:$intrin, Variadic:$args);
+ let arguments = (ins StrAttr:
electriclilies updated this revision to Diff 525815.
electriclilies added a comment.
fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
m
electriclilies added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleT
Mogball added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleTranslat
Mogball added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleTranslat
electriclilies added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleT
Mogball added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleTranslat
Mogball added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleTranslat
electriclilies added inline comments.
Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98
static LogicalResult
convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder,
LLVM::ModuleTranslation &moduleT
Mogball added inline comments.
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:870
-def LLVM_CallIntrinsicOp : LLVM_Op<"call_intrinsic"> {
+def LLVM_CallIntrinsicOp : LLVM_Op<"call_intrinsic",
[DeclareOpInterfaceMethods]> {
let summary = "Call to an LLVM in
electriclilies added inline comments.
Comment at:
mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:130
- llvm::CallInst *inst =
builder.CreateCall(fn, moduleTranslation.lookupValues(op.getOperands()));
ftynse wrote:
> Don't use `auto`
electriclilies updated this revision to Diff 525779.
electriclilies added a comment.
Remove whitespace
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrins
ftynse added inline comments.
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367
// that can be valid on the real entry.
- // This is what I want to do
AttributeList NewAttrs = AttributeList::get(Ctx,
AttributeList::FunctionIndex,
electriclilies wrote:
>
electriclilies updated this revision to Diff 525778.
electriclilies added a comment.
Squish commits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
Files:
mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicO
electriclilies added inline comments.
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367
// that can be valid on the real entry.
- // This is what I want to do
AttributeList NewAttrs = AttributeList::get(Ctx,
AttributeList::FunctionIndex,
ftynse wrote:
>
electriclilies added a comment.
For some reason the diff is showing the difference between 2 commits on my
branch, anyone know how to fix this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151492/new/
https://reviews.llvm.org/D151492
___
ftynse added inline comments.
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367
// that can be valid on the real entry.
- // This is what I want to do
AttributeList NewAttrs = AttributeList::get(Ctx,
AttributeList::FunctionIndex,
This cleanup should go
electriclilies created this revision.
Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski,
sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes,
jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob,
antiagainst, shauhe
23 matches
Mail list logo
