This revision was automatically updated to reflect the committed changes.
Closed by commit rG06ff9770477d: [clang][ExtractAPI] Refactor serializer to the
CRTP (authored by evelez7, committed by dang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151
evelez7 updated this revision to Diff 526148.
evelez7 added a comment.
Address review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151477/new/
https://reviews.llvm.org/D151477
Files:
clang/include/clang/ExtractAPI/Serialization/Seriali
dang added a comment.
LGTM with minor changes
Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:58
- virtual ~APISerializer() = default;
};
It would be nice to keep this as default, i.e.
```
~APISetVisitor() = default;
```
===
evelez7 created this revision.
evelez7 added reviewers: dang, zixuw.
Herald added a reviewer: ributzka.
Herald added a project: All.
evelez7 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Refactor SerializerBase and SymbolGraphSerializer t
