This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b93e15bcd9a: [Clang][SVE2p1] Add svpsel builtins (authored
by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.
CarolineConcatto updated this revision to Diff 557756.
CarolineConcatto added a comment.
-Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.llvm.org/D151197
Files:
clang/include/clang/Basic/arm_sve.td
clang/lib/C
kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.
Thank you for updating this @CarolineConcatto, LGTM
Comment at: clang/include/clang/Basic/arm_sve.td:1886
+
+
nit: extra whitespace
Repository:
CarolineConcatto updated this revision to Diff 557739.
CarolineConcatto added a comment.
-Remove immediate+base from psel and rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151197/new/
https://reviews.llvm.org/D151197
Files:
clang/include/
CarolineConcatto added inline comments.
Herald added a subscriber: wangpc.
Comment at: clang/include/clang/Basic/arm_sve.td:2123
+
+def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone,
"", [], [ImmCheck<3, ImmCheck0_15>]>;
+def SVPSEL_COUNT_ALIAS_H : SIn
hassnaa-arm added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9633-9635
+bool IsSVCount = isa(Ops[0]->getType());
+assert(((!IsSVCount || cast(Ops[0]->getType())->getName() ==
+ "aarch64.svcount")) &&
hassnaa
hassnaa-arm added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:2123
+
+def SVPSEL_COUNT_ALIAS_B : SInst<"svpsel_lane_c8", "}}Pmi", "Pc", MergeNone,
"", [], [ImmCheck<3, ImmCheck0_15>]>;
+def SVPSEL_COUNT_ALIAS_H : SInst<"svpsel_lane_c16", "}}Pmi", "Ps", Mer
CarolineConcatto created this revision.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a project: All.
CarolineConcatto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
As described in: https://github.com/ARM-software/acle/p