[PATCH] D151162: Add -Wpacked-non-pod to -Wall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG916897444778: Reapply: [clang][diagnostics] Adding -Wpacked-non-pod to -Wall (authored by SlaterLatiao, committed by erichkeane). Changed prior to c

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525744. SlaterLatiao added a comment. Adding back the `-triple` flag - The padding size can be different on different architectures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://revie

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. I shouldn't remove `-triple=x86_64-none-none` in the test case. I'll add it back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 ___

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Unfortunately, I had to revert this in 5c8d44d690f6e8fd6f31803aecb17329cdb5 due to a bot breaking: https

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed3d85e26d8: [clang][diagnostics] Add -Wpacked-non-pod to -Wall (authored by SlaterLatiao, committed by aaron.ballman). Changed prior to commit:

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. In D151162#4373027 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? If so, what name and > email address would you like us to use for patch attribution? Thank you, Aaron! Please use Zenong Zhan

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

denik accepted this revision. denik added a comment. Thanks @SlaterLatiao! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 ___ cfe-commits mailing list cfe-comm

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like us to use for patch attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525654. SlaterLatiao added a comment. - Fix missing parenthesis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525653. SlaterLatiao added a comment. - Test behavior of `-Wpacked-non-pod` in `-Wall` and update test case name. - Update release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://re

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman added a comment. In D151162#4369717 , @SlaterLatiao wrote: > In D151162#4369584 , @aaron.ballman > wrote: > >> Please be sure to add a release note for the change, and it'd probably be >> good to

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added a comment. In D151162#4369584 , @aaron.ballman wrote: > Please be sure to add a release note for the change, and it'd probably be > good to have a test case that shows this triggers under `-Wall` (the modified > test case explicitly

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:5 +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -fclang-abi-compat=15 %s -emit-l

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

aaron.ballman added a comment. Please be sure to add a release note for the change, and it'd probably be good to have a test case that shows this triggers under `-Wall` (the modified test case explicitly names the diagnostic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:5 +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -fclang-abi-compat=15 %s -em

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 525280. SlaterLatiao added a comment. - Removed the -triple flag from warn-padded-packed testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162 Files: clang

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

denik added inline comments. Comment at: clang/test/CodeGenCXX/warn-padded-packed.cpp:4 +// -Wpacked-non-pod itself should not emit the "packed attribute is unnecessary" warnings. +// RUN: %clang_cc1 -triple=x86_64-none-none -Wpacked-non-pod -verify=top %s -emit-llvm-only +// R

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D151162

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao updated this revision to Diff 524909. SlaterLatiao added a comment. Test -packed-non-pod not omitting warnings of "packed attribute is unnecessary". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D15

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

dblaikie added a comment. Yeah, looks consistent with GCC ( https://godbolt.org/z/EGc3Ec9YT ), as you say - so I'm OK with it. But wouldn't mind a second opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151162/new/ https://reviews.llvm.org/D

[PATCH] D151162: Add -Wpacked-non-pod to -Wall

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151162 Files: clang/include/clang/Basic/Diagno