[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc81d2a4d5b3: [OpenMP] Fix using the target ID when using the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D150998?vs=523924&id=529476#toc Repository: rG LLVM G

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150998/new/ https://reviews.llvm.org/D150998 __

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. In D150998#4403444 , @yaxunl wrote: > what happens to > > clang -xhip a.c --offload-arch=gfx90a:xnack+ --offload-arch=gfx90a:xnack- > --offload-new-driver -fgpu-rdc > clang -xhip b.c --offload-arch=gfx90a:xnack+ --offload-arc

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added a comment. In D150998#4403416 , @jhuber6 wrote: > In D150998#4403401 , @yaxunl wrote: > >> In D150998#4403359 , @jhuber6 >> wrote: >> >>> Can we use this app

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. In D150998#4403401 , @yaxunl wrote: > In D150998#4403359 , @jhuber6 wrote: > >> Can we use this approach for now and land this? It makes the "new driver" >> less broken than it currently

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added a comment. In D150998#4403359 , @jhuber6 wrote: > Can we use this approach for now and land this? It makes the "new driver" > less broken than it currently is as it supports target ID compilation in the > general term. Fixing the merging ru

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added a comment. Can we use this approach for now and land this? It makes the "new driver" less broken than it currently is as it supports target ID compilation in the general term. Fixing the merging rules will be a rather large overhaul so I'd like this to work in the meantime. This

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8475 "triple=" + TC->getTripleString(), -"arch=" + Arch.str(), +"arch=" + getProcessorFromTargetID(TC->getTriple(), Arch).str(), "kind=" + Kind.str(), ---

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8475 "triple=" + TC->getTripleString(), -"arch=" + Arch.str(), +"arch=" + getProcessorFromTargetID(TC->getTriple(), Arch).str(), "kind=" + Kind.str(), -

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8475 "triple=" + TC->getTripleString(), -"arch=" + Arch.str(), +"arch=" + getProcessorFromTargetID(TC->getTriple(), Arch).str(), "kind=" + Kind.str(), --

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8475 "triple=" + TC->getTripleString(), -"arch=" + Arch.str(), +"arch=" + getProcessorFromTargetID(TC->getTriple(), Arch).str(), "kind=" + Kind.str(), ---

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8465-8470 +if (TC->getTriple().isAMDGPU()) { + for (StringRef Feature : llvm::split(Arch.split(':').second, ':')) { +FeatureArgs.emplace_back( +Args.MakeArgString(Feature

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

saiislam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8465-8470 +if (TC->getTriple().isAMDGPU()) { + for (StringRef Feature : llvm::split(Arch.split(':').second, ':')) { +FeatureArgs.emplace_back( +Args.MakeArgString(Featur

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, carlo.bertolli, yaxunl, saiislam. Herald added subscribers: sunshaoce, kerbowa, guansong, tpr, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sst