[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added a comment. In D150803#4454164 , @brendandahl wrote: > In D150803#4440802 , @aaron.ballman > wrote: > >> Marking as requested changes so it's clear there's more worth discussing, so >> we don't acci

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added a comment. In D150803#4440802 , @aaron.ballman wrote: > Marking as requested changes so it's clear there's more worth discussing, so > we don't accidentally land this. I've switched to using `annotate` now. Let me know if there's anyt

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 535126. brendandahl added a comment. Use the annotate attribute to generate custom sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: lld/test/was

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be used

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be used

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Marking as requested changes so it's clear there's more worth discussing, so we don't accidentally land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will be

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5608-5612 +Clang supports the ``__attribute__((wasm_async))`` +attribute for the WebAssembly target. This attribute may be attached to a +function definition, which indicates the function will

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl added a comment. @aaron.ballman or @erichkeane Did you want to re-review after that latest changes (more generic attribute) or are things good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D1

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sunfish added a comment. In D150803#4419436 , @sbc100 wrote: > Did you mean to comment on the old PR? This new PR doesn't propose either > "jspi" or "async", but adds that ability to define custom attributes.. since > that was deemed more flexible and

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 531390. brendandahl marked an inline comment as done. brendandahl added a comment. Review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: clang

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl marked 4 inline comments as done. brendandahl added inline comments. Comment at: lld/test/wasm/custom-undefine.s:17 +.type bar,@function +bar: +.functype bar () -> () dschuff wrote: > I don't fully understand how this test is d

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 added a comment. In D150803#4419370 , @sunfish wrote: > Would it make sense to call this "jspi" in practice, rather than "async"? > Even though this isn't clang's decision per se anymore, it seems like the > reasoning earlier in this review would

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sunfish added a comment. Would it make sense to call this "jspi" in practice, rather than "async"? Even though this isn't clang's decision per se anymore, it seems like the reasoning earlier in this review would still apply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Nice! Comment at: lld/test/wasm/merge-custom-attr-section.ll:47 +} + +attributes #0 = { "wasm-custom"="custom0" } Is there some reason we can't use assembly

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

dschuff added a comment. oh also: please add the new relocation type to the document at https://github.com/WebAssembly/tool-conventions/blob/main/Linking.md Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

dschuff added a comment. backend code looks pretty good. I'll defer to the clang experts for the clang part. Comment at: lld/test/wasm/custom-undefine.s:17 +.type bar,@function +bar: +.functype bar () -> () I don't fully understand how

[PATCH] D150803: Add a new `wasm_custom` clang attribute for marking functions.

brendandahl updated this revision to Diff 531014. brendandahl added a comment. Fix few remaining issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files: clang/docs/ReleaseNotes.rst clang/includ