[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa825f3754b3c: [CUDA] Relax restrictions on GPU-side variadic functions (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. OK, sgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150718/new/ https://reviews.llvm.org/D150718 __

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

tra updated this revision to Diff 523109. tra added a comment. test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150718/new/ https://reviews.llvm.org/D150718 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

tra added a comment. In D150718#4348737 , @jlebar wrote: > This seems a little dangerous -- we're saying the frontend will accept this > but we can't generate code for it? What happens if we try to generate code? > Do we get some sort of error, or do

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

yaxunl added a comment. could make the diagnostic about variadic functions a deferred diagnostic, then the diag will only be emitted if the function is really emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150718/new/ https://reviews.llvm.

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

jlebar added a comment. This seems a little dangerous -- we're saying the frontend will accept this but we can't generate code for it? What happens if we try to generate code? Do we get some sort of error, or do we silently fail? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra added reviewers: jlebar, yaxunl. tra published this revision for review. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Allow parsing GPU-side