[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos added a comment. Landed, thanks for your patience. Lets hope it sticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 ___ cfe-commits mailing list cfe-

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

This revision was automatically updated to reflect the committed changes. Closed by commit rG9485d983ac0c: [InstCombine] Disable generation of fshl/fshr for rotates (authored by pmatos). Changed prior to commit: https://reviews.llvm.org/D150670?vs=527326&id=527395#toc Repository: rG LLVM Git

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM, let's give it a try. The patch description needs an update though. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:920 +return I;

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4383823 , @nikic wrote: > Can you please drop all wasm related tests and instead add an InstCombine > test for the fsh+and pattern? > > It would also be good to have a test where we can fold one side to a > constant, b

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 527326. pmatos added a comment. Simplify code according to @nikic suggestion. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files: llvm/lib/Transforms/I

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

nikic added a comment. Can you please drop all wasm related tests and instead add an InstCombine test for the fsh+and pattern? It would also be good to have a test where we can fold one side to a constant, but that constant is not zero. We should then consider whether that is profitable or not