[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-16 Thread Sergei Barannikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd522c2f39d51: [clang] Convert several OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. In D150608#4344170 , @jdoerfert wrote: > LG, assuming these are stable now. > > We should move them to the update scripts though... I'm not sure what you mean by this? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, assuming these are stable now. We should move them to the update scripts though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15060

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. I first manually converted a few tests (mostly with regexes), then I checked that the script produces the same result. The result was identical to the letter. The rest of the

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Did you manually update these tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 updated this revision to Diff 522342. barannikov88 added a comment. Throw in a few more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 Files: clang/test/OpenMP/master_taskloop_codege

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] = a

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

2023-05-15 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] = a