This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d2e141e5c0d: [clang][Interp] Handle lambda static invokers
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D150111?vs=52
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150111/new/
https://reviews.llvm.org/D150111
___
cfe-commits mailing lis
tbaeder updated this revision to Diff 522587.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150111/new/
https://reviews.llvm.org/D150111
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.h
clang/lib/AST/I
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103
+ bool IsEligibleForCompilation =
+ FuncDecl->isConstexpr() ||
+ (isa(FuncDecl) &&
+ cast(FuncDecl)->isLambdaStaticInvoker());
aaron.ballman wrote:
> I do
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103
+ bool IsEligibleForCompilation =
+ FuncDecl->isConstexpr() ||
+ (isa(FuncDecl) &&
+ cast(FuncDecl)->isLambdaStaticInvoker());
I don't like the `isa
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150111/new/
https://reviews.llvm.org/D150111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 520331.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150111/new/
https://reviews.llvm.org/D150111
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.h
clang/lib/AST/I
tbaeder updated this revision to Diff 520330.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150111/new/
https://reviews.llvm.org/D150111
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.cpp
clang/lib/AST/Interp/ByteCodeStmtGen.h
clang/lib/AST/I
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Emit custom byte code for the static invoker functi