This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10020791b18f: [clang][Interp] Call invalid destructors
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D150040?vs=520092&
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150040/new/
https://reviews.llvm.org/D150040
_
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150040/new/
https://reviews.llvm.org/D150040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:606
+S{}; // ref-note {{in call to '&S{}->~S()'}}
+return 1; // expected-note {{in call to '&S{}->~S()'}}
+ // FIXME: ^ Wrong line
erichkeane wrote:
> Which DTOR is
erichkeane added inline comments.
Comment at: clang/test/AST/Interp/records.cpp:606
+S{}; // ref-note {{in call to '&S{}->~S()'}}
+return 1; // expected-note {{in call to '&S{}->~S()'}}
+ // FIXME: ^ Wrong line
Which DTOR is happening here th
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We need to call them like any other function, so