[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9857caf9d14f: [Clang] Correctly handle allocation in template arguments (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this looks right, and you've satisfied all the other reviewers. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520356. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520316. cor3ntin added a comment. Fix release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

Fznamznon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:385 +- Fix handling of constexpr dynamic memory allocations in template + arguments. (`#62462 `) Not an expert in this, but I assume `_`

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520154. cor3ntin added a comment. Update commit message and add comment referencing the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15357 - if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects) -return false; + { +FullExpressionRAII Scope(Info); Can you add a comment explaining why t

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520085. cor3ntin added a comment. Address @tbaeder feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15356-15360 - if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects) + FullExpressionRAII Scope(Info); + if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSide

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #62462 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.r