This revision was automatically updated to reflect the committed changes.
Closed by commit rG26f476286fbc: [clang-tidy] Support SystemHeaders in
.clang-tidy (authored by carlosgalvezp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149899/new/
https
carlosgalvezp updated this revision to Diff 520152.
carlosgalvezp added a comment.
Revert unwanted change to UseColor
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149899/new/
https://reviews.llvm.org/D149899
Files:
clang-tools-extra/clang-tidy/
carlosgalvezp updated this revision to Diff 520151.
carlosgalvezp added a comment.
Herald added a subscriber: arphaman.
- Add test where both command line and config settings are used.
- Document that the command-line option overrides the config option, for
consistency with other command-line opt
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11
+// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='.*' -config='SystemHeaders: false' %s -- -isystem
%S/Inputs/system-headers 2>&1 | Fil
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11
+// RUN: clang-tidy -checks='-*,google-explicit-constructor'
-header-filter='.*' -config='SystemHeaders: false' %s -- -isystem
%S/Inputs/system-headers 2>&1
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
From functionally point of view, LGTM.
Comment at:
clang-tools-extra/test/clang-tidy/infrastructure/system-headers.cpp:11
+// RUN: clang-tidy -checks='-*,google-explicit
carlosgalvezp updated this revision to Diff 519633.
carlosgalvezp edited the summary of this revision.
carlosgalvezp added a comment.
Update commit message with Github issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149899/new/
https://reviews
carlosgalvezp created this revision.
Herald added subscribers: PiotrZSL, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
carlosgalvezp requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
A previous patch u