[PATCH] D149809: [Clang][Docs] Fix man page build

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb63fb5d45e0: [Clang][Docs] Fix man page build (authored by aidengrossman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.o

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809 __

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added a comment. Thank you very much for your patience and writing everything out. That makes a lot more sense. The resulting code definitely has a lot more desirable properties. I've updated the diff in accordance with your suggestions. Repository: rG LLVM Github Monorepo CHA

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman updated this revision to Diff 519622. aidengrossman marked 6 inline comments as done. aidengrossman added a comment. Adjust based on reviewer suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. In D149809#4317763 , @aidengrossman wrote: > In D149809#4317610 , @tstellar > wrote: > >> I think we could remove some of the duplication by making the docs_target >> parameter into a

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added a comment. In D149809#4317610 , @tstellar wrote: > I think we could remove some of the duplication by making the docs_target > parameter into a list and passing both docs-clang-html and docs-clang-man to > it. If I'm understanding t

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. I think we could remove some of the duplication by making the docs_target parameter into a list and passing both docs-clang-html and docs-clang-man to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added reviewers: aaron.ballman, tstellar, rnk. aidengrossman added a comment. Posting this as when I was setting up a new dev environment with `-DLLVM_ENABLE_SPHINX`, it defaults to having `SPHINX_OUTPUT_HTML` and `SPHINX_OUTPUT_MAN` on, and the man build was broken so when I tried

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the man page build. It currently doesn't work as SOURCE_DIR isn't set correctly (just undefined