This revision was automatically updated to reflect the committed changes.
Closed by commit rG1c282052624f: [clang-tidy] Optimize performance of
RenamerClangTidyCheck (authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149723/new/
h
PiotrZSL updated this revision to Diff 519924.
PiotrZSL marked 3 inline comments as done.
PiotrZSL added a comment.
Use operator + instead of hash_combine.
Use TraverseAST.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149723/new/
https://reviews.
PiotrZSL marked 3 inline comments as done.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:47
-std::hash SecondHash;
-return DenseMapInfo::getHashValue(Val.first) +
- SecondHash(Val.second);
+return
njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.
Mostly looks good, just a few small nits
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:47
-std::hash SecondHash;
-return DenseMapInfo
PiotrZSL created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Refactor RenamerClangTi