[PATCH] D149650: Give NullabilityKind a printing operator<

cmtice added a comment. This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149650/new/ https://reviews.llvm.org/D149

[PATCH] D149650: Give NullabilityKind a printing operator<

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a532207b869: Give NullabilityKind a printing operator<< (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added a comment. Thanks Aaron! The check is not going to be ready for upstreaming really soon - plenty of thorny issues to work out first, and checking in a half-working version would do more harm than good. But that's definitely the goal once we have some deployment experience. Rep

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149650#4319461 , @sammccall wrote: > In D149650#4316138 , @aaron.ballman > wrote: > >> In D149650#4315211

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added a comment. In D149650#4316138 , @aaron.ballman wrote: > In D149650#4315211 , @sammccall > wrote: > >> In D149650#4312389 , >> @aaron.ballman wrote: >> >

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. In D149650#4315211 , @sammccall wrote: > In D149650#4312389 , @aaron.ballman > wrote: > >> I guess I'm not seeing much motivation for this change. We already have >> `clang::getNul

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall updated this revision to Diff 519046. sammccall added a comment. Make diagnostic-printing use the (other) existing function, come out neutral! (This adds quotes to some diagnostic, but their omission seems to be an error) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added a reviewer: aaron.ballman. sammccall added a comment. In D149650#4312389 , @aaron.ballman wrote: > I guess I'm not seeing much motivation for this change. We already have > `clang::getNullabilitySpelling()` and `const StreamingDiagnostic

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. I guess I'm not seeing much motivation for this change. We already have `clang::getNullabilitySpelling()` and `const StreamingDiagnostic &clang::operator<<(const StreamingDiagnostic &DB, DiagNullabilityKind nullability)` and now we're adding a third way to get thi

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:852 +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, NullabilityKind NK) { + switch (NK) { IdentifierTable.cpp is a weird place to implement this function (I put it next to

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall created this revision. sammccall added a reviewer: mboehme. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is more useful for debug/test than getNullabilitySpelling: - default form has