This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2528f1c84588: [Clang] Correctly expand pack in binary
subscript expression. (authored by cor3ntin).
Repository:
rG LLVM Github Monorepo
CHANGES S
cor3ntin updated this revision to Diff 518776.
cor3ntin added a comment.
Add release note
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149637/new/
https://reviews.llvm.org/D149637
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaExpr.cpp
cor3ntin added inline comments.
Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101
+ int arr[] = {1, 2, 3};
+ return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a
subscript operator}}
+}
shafik wrote:
> The diagnostic is not g
shafik accepted this revision.
shafik added a comment.
LGTM, other than my comment on the diagnostic wording
Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101
+ int arr[] = {1, 2, 3};
+ return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a
s
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When constructing an array expression where the index expression
was a pack expansion, we would construct an ArraySubscrip
