[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG07996804a0c0: [NFC] ][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://review

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added a comment. In D149461#4323175 , @tahonermann wrote: > These changes look good to me and I agree with not making a change for the > `KnownHeaders` case. >> I agree with not making a change for the `KnownHeaders` case. Yup. I closed them a

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. These changes look good to me and I agree with not making a change for the `KnownHeaders` case. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1131-1132

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518375. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518373. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518347. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serializ

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7696 if (isa(DC)) { -for (auto Lexical : TULexicalDecls) +for (const auto &Lexical : TULexicalDecls) Visit(Lexical.first, Lexical.second); This returns `std::vector`

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4428 // Mark selectors as out of date. - for (auto Sel : SelectorGeneration) + for (const auto &Sel : SelectorGeneration) SelectorOutOfDate[Sel.first] = true; Here Object of

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 517964. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: jdoerfert. Herald added sub