[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane abandoned this revision. erichkeane added a comment. Fixed by Richard! Tests and release note added in f539bffc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149264/new/ https://reviews.llvm.org/D149264 ___ cfe-commits mailing lis

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. Confirmed this is all fixed by your patch. Thanks! Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:138-144 +bool SkipForSpecialization, +bool ForConstraintInstantiation) { if (!ClassTemplSpec

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:138-144 +bool SkipForSpecialization, +bool ForConstraintInstantiation) { if (!ClassTemplSpec->isClassScopeExplicitSpecialization()) { // We

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

rsmith added a comment. I think that the bugs that this was aiming to fix were fixed by rG1e43349e321694d7fee3d77cb691887ad67fb5d7 , which means that we should not ask whether the constraints of an inherited constructor are s

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. In D149264#4299877 , @erichkeane wrote: > Creduced the new crash down to: > > template struct a; > template <> struct a { > template constexpr static c e(b, c) { > typename b ::f d; > } > }; > int h; >

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. Creduced the new crash down to: template struct a; template <> struct a { template constexpr static c e(b, c) { typename b ::f d; } }; int h; I'll end up having to look at it tomorrow, but it isn't clear how this patch broke that. CHANGES SI

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane added a comment. This actually doesn't fix the original reproducer of #62344, or at least, it breaks it in a different way. Working to reduce that I guess! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149264/new/ https://reviews.llvm.org/D149264 _

[PATCH] D149264: GH62362: Handle constraints on "Using" inherited constructors

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Two similar bugs were filed, both captured in GH62362. The problem happens when collecting the instantiation args for a constructor with a c