[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGf649599ea933: [CMake] Use LLVM own tools in extract_symbols.py (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/new/ https://revi

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

jhenderson added a comment. In D149119#4331207 , @ikudrin wrote: > In D149119#4329274 , @tmatheson > wrote: > >> LGTM, thank you for doing this. Please give it a couple of days in case >> others have comments. >

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

ikudrin added a comment. In D149119#4329274 , @tmatheson wrote: > LGTM, thank you for doing this. Please give it a couple of days in case > others have comments. Thanks! In D149119#4329285 , @jhenderson wrote:

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

beanz added a comment. One potential area of concern here: If `llvm-driver` is ever extended to work as a plugin loader (thus exporting its symbols), removing support for the pre-installed host tools could cause a cyclic dependency. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

jhenderson added a comment. I've not really looked into this patch significantly, so this may well be addressed in the patch, given I see you have modified stuff to do with the NATIVE build, but in the past I have seen LLVM using its own tools to build other parts of its system. I believe it wa

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, thank you for doing this. Please give it a couple of days in case others have comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/new/ https://reviews.llvm.org

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

ikudrin updated this revision to Diff 520277. ikudrin retitled this revision from "[CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows" to "[CMake] Use LLVM own tools in extract_symbols.py". ikudrin edited the summary of this revision. ikudrin added reviewers: chandlerc, beanz