[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb492316399a: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

simonbutcher accepted this revision. simonbutcher added a comment. > we definitely use -Wsystem-headers. Fair enough, that hadn't occurred to me. The change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. I agree it makes sense to remove the typedef if they are also defined in `arm_bf16.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14882

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim added a comment. In D148822#4305188 , @simonbutcher wrote: > I can't see anything wrong with this patch and it looks pretty > straightforward to me, but is it necessary? > > '-Wtypedef-redefinition' is documented as not applying to system headers >

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

simonbutcher added a comment. I can't see anything wrong with this patch and it looks pretty straightforward to me, but is it necessary? '-Wtypedef-redefinition' is documented as not applying to system headers

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim updated this revision to Diff 515409. dim added a comment. Also fix up arm_sve.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D148822 Files: clang/utils/TableGen/NeonEmitter.cpp clang/utils/TableGen/S

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim created this revision. dim added reviewers: t.p.northover, fpetrogalli, sdesmalen, az, LukeGeeson, stuij. Herald added a project: All. dim requested review of this revision. Herald added a project: clang. As of https://reviews.llvm.org/D79708, clang-tblgen generates both `arm_neon.h` and `arm