Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-25 Thread Alexey Bataev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254063: [X86] Support for C calling convention only for MCU target. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D14864?vs=41004&id=41115#toc Repository: rL LLVM http://re

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-24 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM. http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-24 Thread David Kreitzer via cfe-commits
DavidKreitzer added a comment. Looks good, Alexey! I have no further comments. - Dave http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 41004. ABataev added a comment. Renamed MCU target class http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === --- lib/

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread David Kreitzer via cfe-commits
DavidKreitzer added a comment. Thanks, Alexey! I think this is an improvement. I don't know if anyone else has an opinion on the name of the new class, but I would prefer X86 over I386, possibly even MCUX86_32TargetInfo. Thanks, - Dave http://reviews.llvm.org/D14864 __

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev updated this revision to Diff 40904. http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/Sema/callingconv-iamcu.c Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ lib/Basic/Targets.cpp @@ -3391

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-23 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Ok, extracted all MCU specific changes to separate target class. http://reviews.llvm.org/D14864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-20 Thread David Kreitzer via cfe-commits
DavidKreitzer added a comment. Hi Alexey, Did you consider adding a new class for the MCU target info, e.g. X86MCUTargetInfo? The more MCU-specific stuff that gets added here, the more it makes sense to pull it out into its own class. We already have line 3398-3401 & 3650-3653. We are also go

[PATCH] D14864: [X86] Support for C calling convention only for MCU target.

2015-11-20 Thread Alexey Bataev via cfe-commits
ABataev created this revision. ABataev added reviewers: rjmccall, DavidKreitzer, mkuper. ABataev added a subscriber: cfe-commits. For MCU only C calling convention is allowed, all other calling conventions are not supported. http://reviews.llvm.org/D14864 Files: lib/Basic/Targets.cpp test/S