This revision was automatically updated to reflect the committed changes.
Closed by commit rG7c97dc20ab61: [clang] Do not crash on undefined template
partial specialization (authored by Fznamznon).
Changed prior to commit:
https://reviews.llvm.org/D148330?vs=513581&id=517496#toc
Repository:
shafik accepted this revision.
shafik added a comment.
LGTM
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
-if (!hasReachableDefinition(PartialSpec))
+if (PartialSpec->hasDef
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
-if (!hasReachableDefinition(PartialSpec))
+if (PartialSpec->hasDefinition() &&
+
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
-if (!hasReachableDefinition(PartialSpec))
+if (PartialSpec->hasDefinition() &&
+
shafik added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
-if (!hasReachableDefinition(PartialSpec))
+if (PartialSpec->hasDefinition() &&
+!h
erichkeane accepted this revision.
erichkeane added a comment.
Thanks! still LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148330/new/
https://reviews.llvm.org/D148330
___
cfe-commits mailing list
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:1
+// RUN: %clang_cc1 -std=c++20 -verify %s
+
erichkeane wrote:
> nit: can you add a c++17 run line here too? Only 20 crashed, but I want to
> make sure these h
Fznamznon updated this revision to Diff 513581.
Fznamznon added a comment.
Test c++17 too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148330/new/
https://reviews.llvm.org/D148330
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaCXXScope
erichkeane accepted this revision.
erichkeane added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:1
+// RUN: %clang_cc1 -std=c++20 -verify %s
+
nit: can you add a c++17 run li
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:12
+template
+void boo::foo(){} // expected-error{{nested name specifier 'boo::' for declaration does not refer into a class, class template or class
template partial specializat
Fznamznon updated this revision to Diff 513575.
Fznamznon added a comment.
Rebase, fix error message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148330/new/
https://reviews.llvm.org/D148330
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/S
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
if (!hasReachableDefinition(PartialSpec))
diagnoseMissingImport(SS.getLastQualifierNameLoc(
Fznamznon marked an inline comment as not done.
Fznamznon added inline comments.
Comment at: clang/test/SemaCXX/undefined-partial-specialization.cpp:12
+template
+void boo::foo(){} // expected-error{{nested name specifier 'boo::' for declaration does not refer into a class, class
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
if (!hasReachableDefinition(PartialSpec))
diagnoseMissingImport(SS.getLastQualifierNameLoc()
erichkeane added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134
"specifier in SFINAE context?");
if (!hasReachableDefinition(PartialSpec))
diagnoseMissingImport(SS.getLastQualifierNameLoc(
Fznamznon created this revision.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Before checking that template partial specialization is "reachable",
ensure it exists.
Fixes https://github.com/llvm/ll
16 matches
Mail list logo
