[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

2023-04-14 Thread André Schackier via Phabricator via cfe-commits
AMS21 updated this revision to Diff 513582. AMS21 added a comment. Rename to `performance-avoid-endl` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files: clang-tools-extra/clang-tidy/performance/Avoi

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

2023-04-14 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. For consistency with other checks, please rename it to `performance-avoid-endl`. You can use the `rename_check.py` to easily do this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.o

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

2023-04-14 Thread André Schackier via Phabricator via cfe-commits
AMS21 added a comment. This check is mostly working. Added notes about problems I know about. Comment at: clang-tools-extra/clang-tidy/performance/DontUseEndlCheck.cpp:44 + Diag << FixItHint::CreateReplacement( + CharSourceRange::getCharRange(EndlCall->getSourceRange()),

[PATCH] D148318: [clang-tidy] Add `performance-dont-use-endl` check

2023-04-14 Thread André Schackier via Phabricator via cfe-commits
AMS21 created this revision. AMS21 added a reviewer: PiotrZSL. Herald added subscribers: ChuanqiXu, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber