[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

2023-04-13 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbd41371be02f: [clang] Fix FIXME in isAlignasAttribute() (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148105/new/ https://review

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Huh, this is much less disruptive than I thought it was going to be. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148105/new/ ht

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

2023-04-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. FWIW, the original reason for looking at this was to explore ways of removing `AS_AttributeLikeKeyword` from https://reviews.llvm.org/D139028 . I wanted to find a way of conveying extra information about a spelling without having to change the existing enums. It

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

2023-04-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AttributeCommonInfo::isAlignasAttribute() was used in one