[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

2023-04-13 Thread Richard Sandiford via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG265d87e46535: [clang] Allow attributes to be constructed from keyword tokens (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/ https://revi

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Again, not sold on value, but no problems with the patch itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/ https://reviews.llvm.org/D148103 ___ cfe-commits mai

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

2023-04-12 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds an extra AttributeCommonInfo::Form constr