[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7354fb63471: Keep multiple-include optimization for null directives (authored by IncludeGuardian, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517310. IncludeGuardian added a comment. Rebase on upstream to resolve conflicts in release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. @aaron.ballman If you could commit for me that would be great. Please use "Elliot Goodrich" for the name and "elliotgoodr...@gmail.com" for the email - thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D14792

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 517291. IncludeGuardian added a comment. Update Clang release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Lex/MultipleIncludeOpt

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note to `clang/docs/ReleaseNotes.rst` for the fix. Do you need me to commit on your behalf? If so, please let me know what name and email addres

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian updated this revision to Diff 514849. IncludeGuardian added a comment. Replace `ResetReadToken` with `SetReadToken` to avoid a conditional CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147928/new/ https://reviews.llvm.org/D147928 Files: clang/include/clang/Lex/Multipl

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} aaron.ballman wrote: > NFC but matches our style guide. > > One thing to consi

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1183-1185 +if (!ReadAnyTokensBeforeDirective) { + CurPPLexer->MIOpt.ResetReadToken(); +} NFC but matches our style guide. One thing to consider: making the call a setter

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian added a comment. Differences between the behaviors of compilers can be found here https://github.com/IncludeGuardian/multiple-inclusion-optimization-tests You can see the number of boost preprocessor files failing the include guard optimization when running IncludeGuardian

[PATCH] D147928: [clang] Keep multiple-include optimization for null directives

IncludeGuardian created this revision. IncludeGuardian added a reviewer: clang. IncludeGuardian added a project: clang. Herald added a project: All. IncludeGuardian requested review of this revision. Herald added a subscriber: cfe-commits. The multiple-include optimization allows Clang to avoid op