[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

2023-04-14 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 513669. njames93 added a comment. Updated to work on all special member functions as long as they aren't trivial Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147808/new/ https://reviews.llvm.org/D147808 File

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

2023-04-14 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D147808#4268523 , @kadircet wrote: > there's actually a slight difference between an inline defaulted special > member function and an out-of-line defaulted one. the latter makes the > special member "user-defined" which mig

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

2023-04-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. there's actually a slight difference between an inline defaulted special member function and an out-of-line defaulted one. the latter makes the special member "user-defined" which might cause various headaches (e.g. type is no longer "trivial"). i don't think we should

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

2023-04-07 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Som