[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

Michael137 added a comment. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53d8b59307d4: Fix the two gmoules-prefered-name-* tests (authored by yozhu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. This is an obvious fix and builds are still broken. Go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing l

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

yozhu added a comment. In D147764#4250636 , @chapuni wrote: > FYI it's netter to mention diff id like D145803 > rather than commit hash, as far as is is > based on the diff. Yes, will include diff ID in commit message

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni added a comment. FYI it's netter to mention diff id like D145803 rather than commit hash, as far as is is based on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

chapuni accepted this revision. chapuni added a comment. This revision is now accepted and ready to land. It's obvious. I think it was bad just to swallow stderr there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

smeenai added reviewers: Michael137, dblaikie, aprantl. smeenai added a comment. Thanks! I'm not super familiar with this, so I'm adding the original author and reviewers to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https:

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

yozhu created this revision. Herald added a project: All. yozhu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing "REQUIRES: asserts" for the two tests added in commit 711a64412749ae73709562b591ab1609a3ee7751