[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-18 Thread Bill Wendling via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb51a03e1bbe7: [Clang][NFC] Rename methods/vars to reflect their real usage (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-18 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 514730. void marked an inline comment as done. void added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindT

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-18 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:426 +return IndexCtx.handleReference(FD, D.getFieldLoc(), Parent, +ParentDC, SymbolRoleSet(), {}, E); + } nit Repository:

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-17 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 514395. void added a comment. Reformat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/XRefs

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-17 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.org/D147743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-07 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 511772. void added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.o

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-06 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added reviewers: rsmith, rjmccall, aaron.ballman, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "getField" method is a b