[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

2023-04-05 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. Added the missing release note at rG5bab9097ce5b093289e8d40809d02f002febe910 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/ https://reviews

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

2023-04-05 Thread Zequan Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93bd417445: [Coverage] Fix crash when visiting PseudoObjectExpr. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

2023-04-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this looks much better to me! LGTM, but please add a release note about the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

2023-04-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 510918. zequanwu added a comment. Add the crash repro as test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/ https://reviews.llvm.org/D147569 Files: clang/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

2023-04-04 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: aaron.ballman, gulfem, hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a split of D147073 . Fix