This revision was automatically updated to reflect the committed changes.
Closed by commit rG9b617081420d: [M68k] Add basic Clang support for M68881/2
(authored by myhsu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147481/new/
https://reviews.llv
glaubitz added a comment.
@myhsu Can you fix the typo in the commit message?
s/supports/support/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147481/new/
https://reviews.llvm.org/D147481
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
0x59616e added a comment.
LGTM. Thanks !
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147481/new/
https://reviews.llvm.org/D147481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
myhsu added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147481/new/
https://reviews.llvm.org/D147481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
myhsu updated this revision to Diff 511477.
myhsu marked 2 inline comments as done.
myhsu added a comment.
- Explicit add `isa-68882` even for newer (>=68040) CPUs. Such that's it's a
lot easier to conditionally add related macro definitions with
TargetOptions::FeatureMap
- Add cases to test the
RKSimon added inline comments.
Comment at: clang/test/Driver/m68k-macros.cpp:2
// Check macro definitions
// RUN: %clang -target m68k-unknown-linux -m68000 -dM -E %s | FileCheck
--check-prefix=CHECK-MX %s
+// RUN: %clang -target m68k-unknown-linux -m68000 -mhard-float -dM -E %
myhsu created this revision.
myhsu added reviewers: 0x59616e, RKSimon.
Herald added a project: All.
myhsu requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
- Add the `-m68881` flag
- Add floating point feature detection
- Macro defini
