This revision was automatically updated to reflect the committed changes.
Closed by commit rG92910a51b904: [clang-tidy] fix concat-nest-namespace fix
hint remove the macro (authored by HerrCai0907).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D14719
HerrCai0907 marked 2 inline comments as done.
HerrCai0907 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88
+ StringRef TokText = getRawStringRef(TokRange, SM, LangOpts);
+ if (TokText != "// namespace " + ND->getNameA
HerrCai0907 updated this revision to Diff 511763.
HerrCai0907 marked 4 inline comments as done.
HerrCai0907 added a comment.
reorder fixhint
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147194/new/
https://reviews.llvm.org/D147194
Files:
clang-
HerrCai0907 updated this revision to Diff 511757.
HerrCai0907 added a comment.
Herald added a subscriber: ChuanqiXu.
update according to comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147194/new/
https://reviews.llvm.org/D147194
Files:
cl
PiotrZSL added a comment.
Overall looks +- fine, these are last comments from me.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:127
+
+ for (size_t Index = 0; Index < Namespaces.size(); Index++) {
+if (Namespaces[Index]->isNested())
--
HerrCai0907 updated this revision to Diff 510658.
HerrCai0907 edited the summary of this revision.
HerrCai0907 added a comment.
add feature update close comment in fixhint
update acc. comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147194/new/
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:69
+ }
+ SourceRange{ND->getBeginLoc(), Tok->getEndLoc()}.dump(SM);
+ return SourceRange{ND->getBeginLoc(), Tok->getEndLoc()};
Remove this debug
HerrCai0907 updated this revision to Diff 509860.
HerrCai0907 marked an inline comment as done.
HerrCai0907 added a comment.
refactor some code and add release note
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147194/new/
https://reviews.llvm.org/
HerrCai0907 marked 3 inline comments as done.
HerrCai0907 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:49
const LangOptions &LangOpts) {
// FIXME: This logic breaks when there is a c
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/modernize/Inputs/concat-nested-namespaces/modernize-concat-nested-namespaces.h:8
// CHECK-FIXES: void t();
-// CHECK-FIXES-NEXT: } // namespace nn1
+// CHECK-FIXES-NEXT: } // namespace nn2
--
PiotrZSL added a comment.
You changed half of this check logic, please take a look into those issues for
this check:
https://github.com/llvm/llvm-project/issues/60051
https://github.com/llvm/llvm-project/issues/60048
https://github.com/llvm/llvm-project/issues/60035
https://github.com/llvm/llvm-p
HerrCai0907 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:70
+ File.data() + LocInfo.second, File.end());
+ L.SetCommentRetentionState(WithComment);
+ // Find the token.
This part of code cop
HerrCai0907 created this revision.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
HerrCai0907 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
remove
13 matches
Mail list logo
