[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This diagnostic may be strengthened into an + error again in the future once there is a

[PATCH] D146986: Downgrade reserved module identifier error into a warning

Mordante added a comment. Sorry I was not available earlier. Thanks for working on this. LGTM but one remark. Comment at: clang/docs/ReleaseNotes.rst:92 + `_ and allows easier + building of precompiled modules. This diagnost

[PATCH] D146986: Downgrade reserved module identifier error into a warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGe574833c2bc4: Downgrade reserved module identifier error into a warning (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146986/new

[PATCH] D146986: Downgrade reserved module identifier error into a warning

iains added a comment. +1 for this as an interim solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146986/new/ https://reviews.llvm.org/D146986 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225275 , @dblaikie wrote: > Presumably adding an alias for `#pragma clang system_header` called > `system_module` wouldn't be too hard? (though the pragma is also being > removed from libc++ soon, I think, in f

[PATCH] D146986: Downgrade reserved module identifier error into a warning

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. > Presumably adding an alias for #pragma clang system_header called > system_module wouldn't be too hard? (though the pragma is also being removed > from libc++ soon, I think, in favor o

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. In D146986#4225192 , @aaron.ballman wrote: > In D146986#4225121 , @dblaikie > wrote: > >> From the discussion on the issue: >> >>> Do we want this loosening of the restriction to apply

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman added a comment. In D146986#4225121 , @dblaikie wrote: > From the discussion on the issue: > >> Do we want this loosening of the restriction to apply to *only* `std` and >> the same followed by a number, or to any reserved identifier used i

[PATCH] D146986: Downgrade reserved module identifier error into a warning

dblaikie added a comment. From the discussion on the issue: > Do we want this loosening of the restriction to apply to *only* `std` and the > same followed by a number, or to any reserved identifier used in a module? > e.g., > > module std; // error today, but will become a warning > module

[PATCH] D146986: Downgrade reserved module identifier error into a warning

aaron.ballman created this revision. aaron.ballman added reviewers: ChuanqiXu, dblaikie, Mordante, iains. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Any project that wants to `import std;` potentially needs to be able to build a mo