This revision was automatically updated to reflect the committed changes.
Closed by commit rG81358e9193a9: [clang][MinGW] Add asan DLL lib before other
libs and objects (authored by alvinhochun).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146908/n
mstorsjo added inline comments.
Comment at: clang/test/Driver/mingw-sanitizers.c:2
+// RUN: touch %t.a
+// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address -lcomponent
%/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-I686 -DINPUT=%/t.a %s
+// RUN: %clang -tar
alvinhochun added inline comments.
Comment at: clang/test/Driver/mingw-sanitizers.c:2
+// RUN: touch %t.a
+// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address -lcomponent
%/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-I686 -DINPUT=%/t.a %s
+// RUN: %clang -
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
LGTM overall.
I wondered if the modified test runs correctly on Windows (any test that
touches paths is prone to break) but I see that it seems to have run
successfully on both Windows an
alvinhochun updated this revision to Diff 509030.
alvinhochun retitled this revision from "[clang][MinGW] Add asan link flags
before other libs and objects" to "[clang][MinGW] Add asan DLL lib before other
libs and objects".
alvinhochun added a comment.
Updated per comments.
Repository:
rG L