Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-03 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254682: LLDB JIT needs android vector passing rules. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D14639?vs=41654&id=41837#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Reid Kleckner via cfe-commits
rnk added a comment. lgtm http://reviews.llvm.org/D14639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Stephen Hines via cfe-commits
srhines marked 3 inline comments as done. srhines added a comment. I uploaded a fixed version to use isPowerOf2_32() and more comments. Thanks for the reviews. http://reviews.llvm.org/D14639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 41654. srhines added a comment. Switched to isPowerOf2_32() and added more details about Android's ABI. http://reviews.llvm.org/D14639 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/arm-abi-vector.c Index: test/CodeGen/arm-abi-vector.c

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-02 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. Ouch, that 2012 vector passing ABI break is a bummer. :( Comment at: lib/CodeGen/TargetInfo.cpp:5236 @@ +5235,3 @@ + if (const VectorType *VT = Ty->getAs

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines added a comment. In http://reviews.llvm.org/D14639#300077, @rnk wrote: > Were these changes made to AOSP Clang to match upstream GCC, or some custom > Android version of GCC? Where would one go to find ground truth on how these > types should be passed? These changes are reverting to

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. rnk added a comment. Were these changes made to AOSP Clang to match upstream GCC, or some custom Android version of GCC? Where would one go to find ground truth on how these types should be passed? http://reviews.llvm.org/D14639 _

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines updated this revision to Diff 41560. srhines added a comment. Update vector ABI for Android ARM targets. Summary: Looking into some recent issues with LLDB's expression parser highlighted that upstream clang passes vector types differently than the Android Open Source Project's clang for

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-12-01 Thread Stephen Hines via cfe-commits
srhines commandeered this revision. srhines added a reviewer: ADodds. srhines added a comment. Commandeering, since I am going to upload a version with the updated tests. Repository: rL LLVM http://reviews.llvm.org/D14639 ___ cfe-commits mailing

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-11-13 Thread Stephen Hines via cfe-commits
srhines added a comment. Aidan did ask me about upstreaming this particular (reworked) patch from our Android repository, so I did consent to submitting it. I can try to put together a test case for our particular differences. Repository: rL LLVM http://reviews.llvm.org/D14639 __

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-11-13 Thread David Blaikie via cfe-commits
On Fri, Nov 13, 2015 at 2:00 AM, Aidan Dodds via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ADodds created this revision. > ADodds added reviewers: asl, rsmith. > ADodds added subscribers: pirama, cfe-commits. > ADodds set the repository for this revision to rL LLVM. > Herald added subscri

[PATCH] D14639: LLDB JIT needs android vector passing rules.

2015-11-13 Thread Aidan Dodds via cfe-commits
ADodds created this revision. ADodds added reviewers: asl, rsmith. ADodds added subscribers: pirama, cfe-commits. ADodds set the repository for this revision to rL LLVM. Herald added subscribers: srhines, danalbert, tberghammer, aemerson. Looking into some recent issues with LLDBs expression parse