[PATCH] D146323: inline stmt attribute diagnosing in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG514e4359a543: inline stmt attribute diagnosing in templates (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146323/new/ https://reviews.llvm.org/D146323 ___ cfe-commits

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflicting a

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflicting a

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-alwaysinline.cpp:48 + if constexpr (D>0) { +// expected-warning@+6{{statement attribute 'always_inline' has higher precedence than function attribute 'noinline'}} +// expected-note@#NO_DEP{{conflictin

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane updated this revision to Diff 506680. erichkeane marked 5 inline comments as done. erichkeane added a comment. Changes aaron suggested. Chose zip_longest instead of enumerate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146323/new/ https://reviews.llvm.org/D146323 Files:

[PATCH] D146323: inline stmt attribute diagnosing in templates

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:179 by prioritizing ``-Wunreachable-code-fallthrough``. +- Clang now correctly diagnoses statement attributes ``[[clang::always_inine]]` and + ``[[clang::noinline]]`` when used on a statement with d

[PATCH] D146323: inline stmt attribute diagnosing in templates

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. D146089 's author discovered that our diagnostics for always/no inline would null-dereference when used in