This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5e1a93ea10f: [clang] Fix crash when handling nested
immediate invocations (authored by Fznamznon).
Changed prior to commit:
https://reviews.llvm.org/D146234?vs=509039&id=511027#toc
Repository:
rG LL
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
___
cfe-commits mailing list
cfe-comm
Fznamznon added a comment.
@aaron.ballman , @cor3ntin are you ok with the patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
___
cfe-commits mailing list
cf
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
___
Fznamznon added a comment.
Ping @shafik ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
Fznamznon updated this revision to Diff 509039.
Fznamznon added a comment.
Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
Files:
clang/docs/ReleaseNotes.rst
clang/include/clang/Sema/Se
Fznamznon updated this revision to Diff 508974.
Fznamznon added a comment.
Rebase, add release note, fix grammar
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
Files:
clang/docs/ReleaseNotes.rst
clan
aaron.ballman added a comment.
I think this LGTM, but I'm holding off on signing off until @shafik is
satisfied with the part he was asking about. You should add a release note for
the fix, too.
Comment at: clang/lib/Sema/SemaExpr.cpp:17891-17894
+ // It is possible that
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:17979
+ if (Rec.ImmediateInvocationCandidates.size() > 1 ||
+ SemaRef.FailedImmediateInvocations.size()) {
cor3ntin wrote:
> Shouln't we clear `FailedImmediateInvocations` at the end
cor3ntin added a comment.
Sorry for the late review.
I think this makes sense generally, i just have one question
Comment at: clang/lib/Sema/SemaExpr.cpp:17979
+ if (Rec.ImmediateInvocationCandidates.size() > 1 ||
+ SemaRef.FailedImmediateInvocations.size()) {
-
Fznamznon added a comment.
Ping?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146234/new/
https://reviews.llvm.org/D146234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
Fznamznon added inline comments.
Comment at: clang/lib/Sema/SemaExpr.cpp:17897
+if (SemaRef.FailedImmediateInvocations.contains(E))
+ CurrentII->setInt(1);
+ } else {
shafik wrote:
> It is not obvious to me why this is correct, can you pleas
shafik added a comment.
Thank you for the fix.
Comment at: clang/lib/Sema/SemaExpr.cpp:17897
+if (SemaRef.FailedImmediateInvocations.contains(E))
+ CurrentII->setInt(1);
+ } else {
It is not obvious to me why this is correct, can you pleas
Fznamznon created this revision.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Before this patch it was expected that if there was several immediate
invocations they all belong to the same expression
14 matches
Mail list logo
