[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf47404b012d6: [clang][docs] Clarify the semantics of -fexceptions (authored by asb). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/new/ https://reviews.llvm.org/D145564 ___ cfe-commits mailing list cfe-commi

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb updated this revision to Diff 505060. asb added a comment. Adjust wording based on discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/new/ https://reviews.llvm.org/D145564 Files: clang/docs/CommandGuide/clang.rst Index: clang/docs/CommandGuide/clang.rst ==

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. I don't see anything x86_64 specific for `OPT_fexceptions` handling in clang/lib/Driver/ToolChains/Clang.cpp. So perhaps "For most targets, this is enabled by default for C++." It's disabled for the ps4/ps5 toolchains and xcore, hence the "most targets" qualifier. CHANGES

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. Something like that, sure. Is it actually on by default on x86-64? I don't think the default is target-specific, I think it's just on for default for C++ dialects, and off by default for non-C++ dialects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb added a comment. What do you think about e.g. "Allow exceptions to be thrown through Clang compiled stack frames (on many targets, this will enable unwind information for functions that might have an exception thrown through them. This is on by default in x86-64"? Or were you thinking of so

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma added a comment. I'd prefer to focus the documentation more generically on exceptions, not unwind information specifically. -fexceptions makes code generation change in other ways, and "unwind information" doesn't exist on all targets where exception handling is relevant. CHANGES SI

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb created this revision. asb added a reviewer: efriedma. Herald added subscribers: wingo, pmatos, sameer.abuasal. Herald added a project: All. asb requested review of this revision. As noted in #6126 the documentation for `-fexceptions` appear