This revision was automatically updated to reflect the committed changes.
Closed by commit rG124b46a897a7: [NFC][AArch64] Document and improve FMV code.
(authored by ilinpv).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145538/new/
https://reviews.
ilinpv marked 5 inline comments as done.
ilinpv added inline comments.
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:567-568
+
+// For given features returns a mask to check if CPU support them. The mask is
+// used in Function Multi Versioning resolver conditi
ilinpv updated this revision to Diff 503446.
ilinpv added a comment.
Rebasing and addressing comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145538/new/
https://reviews.llvm.org/D145538
Files:
clang/include/clang/Basic/TargetInfo.h
cla
tmatheson accepted this revision.
tmatheson added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for making these changes.
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:567-568
+
+// For given features returns a mask to check if CPU
aaron.ballman added a comment.
Generally seems reasonable to me, but I'll give others a chance to comment.
Comment at: clang/lib/AST/ASTContext.cpp:13459
if (Target->validateCpuSupports(Feature.str()))
+ // Use '?' to mark features that came from TargetVersion
ilinpv created this revision.
ilinpv added reviewers: tmatheson, danielkiss.
Herald added a subscriber: kristof.beyls.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
ilinpv requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-co
