[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

jplehr added a comment. Hey Krzysztof, I believe this broke the openmp offload buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/30576 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 _

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c1ede2543b: [AMDGPU] Define data layout entries for buffers (authored by krzysz00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 518843. krzysz00 added a comment. Rebase to handle new legalization tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cp

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. It may not be the end step and may be annoying to make further changes from this point, but on its own this isn't worse than before Comment at: llvm/lib/Target/AMDGPU/

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 516953. krzysz00 edited the summary of this revision. krzysz00 added a comment. Make address space 8 non-integral as well because that's a good idea and we'll have an address space cast intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 514232. krzysz00 added a comment. Fix new merge conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/Co

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 512488. krzysz00 added a comment. Rebase, since we have addrspace 128 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp c

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510848. krzysz00 added a comment. Rebase data layout changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 510056. krzysz00 edited the summary of this revision. krzysz00 added a comment. Per discussion on the s.buffer.load revision, don't make those changes, and so revert this patch back to what it used to be. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 509761. krzysz00 edited the summary of this revision. krzysz00 added a comment. Rebase for splitting s.buffer.load effect change into earlier patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ htt

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 507870. krzysz00 added a comment. ... actually fix the typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 updated this revision to Diff 507869. krzysz00 added a comment. Fix typo, rebase while making next patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145441/new/ https://reviews.llvm.org/D145441 Files: clang/lib/Basic/Targets/AMDGPU.cp

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

nhaehnle added a comment. In D145441#4175428 , @krzysz00 wrote: > @foad I was trying to avoid sending in one mega-patch that has the entire > prototype. The best way to do this is to work on a branch that you rebase regularly. You can push the branch t

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 added a comment. @foad I was trying to avoid sending in one mega-patch that has the entire prototype. As to your comments: - Why 256-bit alignment? It's the next power of 2, and using an alignment that isn't a power of 2 causes an assertion failure - Re not being allowed to use addres

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

foad added a comment. Just my 2p: it feels a bit premature to commit patches for this. It feels more like something you could prototype on a branch somewhere and come back when you have more experience with how it all works out in practice. But I don't actually object to the patch, if the other

[PATCH] D145441: [AMDGPU] Define data layout entries for buffers

krzysz00 created this revision. krzysz00 added reviewers: nhaehnle, arsenm, b-sumner, piotr, sstefan1, jdoerfert. Herald added subscribers: kosarev, jeroen.dobbelaere, foad, wenlei, okura, kuter, kerbowa, arphaman, zzheng, hiraditya, arichardson, tpr, dstuttard, yaxunl, jvesely, kzhuravl, MatzeB